[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [IMP-dev] [IMP-commits] r1054 - trunk/kernel/pyext/IMP



Overall I don't really see the benefit of such a feature unless it is going to be used to make it so you can run tests from any cwd (since the correct one is nonobvious) or to separate the test data from the tests so we dont have 4 copies of single_protein.pdb around. And in either of those cases the current directory is a bad default as you have to be elsewhere for almost any other operation (and the commit log messages was poor).

Also, what happened to posting changes to how things work on imp-dev for comment?



On Dec 18, 2008, at 6:58 PM, Notification of IMP commits < > wrote:

Author: 
Date: 2008-12-18 18:58:41 -0800 (Thu, 18 Dec 2008)
New Revision: 1054

Modified:
  trunk/kernel/pyext/IMP/test.py
Log:
Default to current directory if TEST_DIRECTORY is not set.


Modified: trunk/kernel/pyext/IMP/test.py
===================================================================
--- trunk/kernel/pyext/IMP/test.py 2008-12-18 22:28:10 UTC (rev 1053) +++ trunk/kernel/pyext/IMP/test.py 2008-12-19 02:58:41 UTC (rev 1054)
@@ -18,7 +18,9 @@

    def get_test_file(self, filename):
"""Get the full name of a file in the top-level test directory."""
-        path = os.environ['TEST_DIRECTORY']
+        # If individual tests are run manually, assume they are in
+        # the current directory:
+        path = os.environ.get('TEST_DIRECTORY', '.')
        return os.path.join(path, filename)

    def assertInTolerance(self, num1, num2, tolerance, msg=None):

_______________________________________________
IMP-commits mailing list

https://salilab.org/mailman/listinfo/imp-commits