[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[IMP-dev] Proposed change to rigid body helpers



Currently the rigid body helpers and cover helpers return a score state which must be added to the model to have rigid bodies work properly. I think this is confusing and error prone and doesn't offer real benefit. I would propose that the decorators or create functions simply add the score state themselves. We can add a function to tear down the rigid body/cover if people want to be able to turn them off later.

The change would result in a compilation error in C++ and an mismatched type error in python, both of which can be fixed by simply removing the "score_state_variable=" from the "score_state_variable= create...." and the "model->add_score_state(score_state_variable)", so easy enough.

Thoughts? Objections?

The high level object is to make score states something that users are unlikely to have to be aware of: that is, you just create a rigid body and it works.