Re: [IMP-dev] [IMP-commits] r1297 - trunk/modules/algebra/include

[Daniel Russel <>]

I really don't like having the default constructor have some meaning  
like that since you have no way of knowing what it is doing without  
reading the documentation. Much better to have a method produce the  
identity transform.


On Jan 27, 2009, at 10:16 PM, Notification of IMP commits wrote:

> Author: 
> Date: 2009-01-27 22:16:23 -0800 (Tue, 27 Jan 2009)
> New Revision: 1297
>
> Modified:
>   trunk/modules/algebra/include/Transformation3D.h
> Log:
> change to default constrator to initilize the identity transformation
>
> Modified: trunk/modules/algebra/include/Transformation3D.h
> ===================================================================
> --- trunk/modules/algebra/include/Transformation3D.h	2009-01-27  
> 22:26:43 UTC (rev 1296)
> +++ trunk/modules/algebra/include/Transformation3D.h	2009-01-28  
> 06:16:23 UTC (rev 1297)
> @@ -25,6 +25,8 @@
>   typedef Transformation3D This;
>   //! construct and invalid transformation
>   Transformation3D(){
> +    trans_=Vector3D(0.0,0.0,0.0);
> +    rot_ = identity_rotation();
>   }
>   /** basic constructor*/
>   Transformation3D(const Rotation3D& r, const Vector3D& t)
>
> _______________________________________________
> IMP-commits mailing list
>
> https://salilab.org/mailman/listinfo/imp-commits