[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [IMP-dev] patches to embed



keren will be the appropriate addressee.

anyway, some comments from my side:
- thanks for propping up the error handling
- for the endian: best provide a unit test and make sure your files (mrc?) are correct! for example, if your magic number indicates big endian, but the data are actually stored as little endian, your output will be messed up - but the reader works perfectly as it should do. so best take an example from the EMDep for the unit test. might well be there is a problem, but make sure it is not due to messy files.
- in DensityHeader there is a confusing comment:
...
  float Objectpixelsize; //this is the actual pixelsize
  float Microscope;  //Microscope
+  //! Use this to set the size of the voxel
  float Pixelsize; //Pixelsize - used for the microscope CCD camera
...
the comment should probably apply to Objectpixelsize.

best

frido



On Jul 16, 2008, at 1:47 AM, Daniel Russel wrote:

<patches>



--

Friedrich Foerster
Max-Planck Institut fuer Biochemie
Am Klopferspitz 18
D-82152 Martinsried

Tel: +49 89 8578 2651



www.tomotronic.org