Re: [IMP-dev] NBL cleanup and other small patches

[Daniel Russel <>]

O(N) is not is irrelevant. The constants are what matters and they  
were bad. The code I submitted is better, but still not as fast as the  
CGAL one.


On Apr 26, 2008, at 10:56 AM, Ben Webb wrote:

> Daniel Russel wrote:
> > Frido was complaining that the nbl was too slow, so I thought I would
> > check in my local changes. The big thing is that the fastest
> > implementation I have uses the CGAL library.
>
> All patches to IMP need to be reviewed before they are checked in.
> Obviously, I am not going to do this while I'm on vacation, so unless
> somebody else with some understanding of the code volunteers to check
> through these patches, they'll have to wait until I'm back in the lab.
Not that we could do anything even if we did review them...

Aren't you back now?

> I don't think we can use CGAL. It is certainly available for Fedora,  
> but
> we build on a lot of other platforms too. And my understanding is that
> large chunks of it are QPL licensed, which is certainly incompatible
> with the IMP license. If we did use it, we'd have to be very careful  
> to
> use only the LGPL parts. So I'd rather we didn't use it at all.

I thought LGPL could be linked against anything. And I thought IMP was  
going LGPL for exactly this sort of reason. It was a while ago, so I  
don't remember the final decision.